Fix: Signature not showing #8235
Open
+76
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
jamil314
added
💅 Waiting For Review
🚀 Ready to deploy
|
Your environment is deployed to https://ocrvs-6213.opencrvs.dev |
Zangetsu101
requested changes
Dec 23, 2024
Comment on lines
211
to
236
| const resolvedSignatures = await Promise.all( | ||
| SIGNATURE_KEYS.map((k) => ({ | ||
| signatureKey: k, | ||
| url: templateValues[k] | ||
| })) | ||
| .filter(({ url }) => Boolean(url)) | ||
| .map(({ signatureKey, url }) => { | ||
| return fetchImageAsBase64(url as string).then((value) => ({ | ||
| [signatureKey]: value | ||
| })) | ||
| }) | ||
| ).then((res) => res.reduce((acc, cur) => ({ ...acc, ...cur }), {})) | ||
| templateValues = { | ||
| ...templateValues, | ||
| ...resolvedSignatures | ||
| } | ||
|
|
||
| if (templateValues.registrar) { | ||
| fetchImageAsBase64( | ||
| (templateValues.registrar as any).signature as string | ||
| ).then((value) => { | ||
| ;(templateValues.registrar as any).signature = value | ||
| }) | ||
| } | ||
| return executeHandlebarsTemplate(svgTemplate, templateValues, state) | ||
| } |
There was a problem hiding this comment.
Let's make this dynamic
Zangetsu101
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.