Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow supplying a comment with confirmRegistration #8197

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Dec 11, 2024

When death is being registered, MOSIP might not have the supplied NID, or it's already been deactivated. We want to show this in record audit.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it and removed 🚧 work in progress labels Dec 16, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-8178.opencrvs.dev

@naftis naftis deployed to ocrvs-8178 December 20, 2024 02:00 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants