Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocrvs 6909 #8084

Merged
merged 28 commits into from
Dec 24, 2024
Merged

Ocrvs 6909 #8084

merged 28 commits into from
Dec 24, 2024

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Nov 26, 2024

No description provided.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

packages/client/src/views/SearchResult/AdvancedSearch.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a bit more generic as we know that custom events are coming. So the payload for the event could be something like this:

type EventPayload = {
  event: string
  jurisdictionId?: string
}

type IAdvancedSearchParam = {
  event: EventPayload[]
  ...
}

Notice how the jurisdictionId is optional here. So if a user has birth:search:my-jurisdiction, death:search scope, gateway will send something like

[
  { event: 'birth', jurisdictionId: '1234-4567' },
  { event: 'death' }
]

Then we can just map this array to the shouldMatchCondition

@Zangetsu101 Zangetsu101 merged commit 25ade2f into configurable-roles Dec 24, 2024
30 of 32 checks passed
@Zangetsu101 Zangetsu101 deleted the ocrvs-6909 branch December 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants