Simplifying gateways' return values #7863
Open
+93
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
Your environment is deployed to https://ocrvs-2520.opencrvs.dev |
naftis
reviewed
Oct 30, 2024
| @@ -637,7 +596,7 @@ export const resolvers: GQLResolver = { | |||
| return taskEntry.resource.id | |||
| }, | |||
| async confirmRegistration(_, { id }, { headers: authHeader }) { | |||
| if (!inScope(authHeader, ['record.confirm-registration'])) { | |||
| if (!inScope(authHeader, ['record.confirm-registration'] as unknown as Scope[])) { | |||
There was a problem hiding this comment.
The scope should actually be there so no casting
as unknown as Scope[] should be needed
naftis
reviewed
Oct 30, 2024
packages/gateway/src/constants.ts
Outdated
| @@ -16,7 +16,7 @@ export const AVATAR_API = | |||
|
|
|||
| export const NATIVE_LANGUAGE = (() => { | |||
| const languages = env.LANGUAGES.split(',') | |||
| return languages.find((language) => language !== 'en') | |||
| return languages.find((language: string) => language !== 'en') | |||
There was a problem hiding this comment.
This is an unnecessary assertion: the compiler seems to already know it's a string.
There was a problem hiding this comment.
the parameter "language" was being implicitly given an any type which was causing an error when i ran the tests
naftis
requested changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the return values for the gateways' resolver functions.