As a user I want to select a template to issue a certified copy with #7813
+2,331
−1,319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tareq89
force-pushed
the
ocrvs-7584
branch
2 times, most recently
from
184ba01
to
f814ace
Compare
rikukissa
reviewed
Oct 23, 2024
rikukissa
reviewed
Oct 23, 2024
|
Your environment is deployed to https://ocrvs-7584.opencrvs.dev |
rikukissa
reviewed
Oct 25, 2024
rikukissa
reviewed
Oct 25, 2024
rikukissa
reviewed
Oct 25, 2024
rikukissa
reviewed
Oct 25, 2024
rikukissa
reviewed
Oct 25, 2024
rikukissa
reviewed
Oct 25, 2024
...lient/src/forms/register/mappings/event-specific-fields/birth/query/registration-mappings.ts
Outdated
Show resolved
Hide resolved
tareq89
force-pushed
the
ocrvs-7584
branch
2 times, most recently
from
bdc01ca
to
e21b0ea
Compare
|
Seems the dropdown and the radio buttons in a different order to how the design is:
|
rikukissa
reviewed
Oct 31, 2024
packages/client/src/views/PrintCertificate/collectorForm/CollectorForm.tsx
Outdated
Show resolved
Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts
Outdated
Show resolved
Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts
Show resolved
Hide resolved
I did not know such design existed. Any figma link of this design was not mentioned anywhere. Anyway, I have adjusted the code as per the design. |
rikukissa
reviewed
Nov 1, 2024
rikukissa
approved these changes
Nov 5, 2024
* refactor: move metrics out of authenticate * feat: initial token exchange endpoint * chore: update comment to be more specific * fix: issue with calling metrics environment * chore: amend changelog * refactor: improve clarity * fix: unused import * chore: add missing schema inputs * revert: revert mosip code removal to keep PR contained * chore: add comment about more fine-grained control * chore: fix test on gateway * feat: actually check if the record id matches to confirm record * revert: the confirm registration changes - lets do inanother pr * refactor: update error messages * fix: make the no-op simpler * fix: the query params not passing properly via gateway * refactor: remove unnecessary gql inputs * fix: update audiences to include minimum * fix: update the todo comment
…g Documentrefences
Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com>
Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7584
Country config PR: opencrvs/opencrvs-countryconfig#290
Farajaland PR: opencrvs/opencrvs-farajaland#1154