Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ocrvs 7002 client modal glitches on Integrations page #7056

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix: Ocrvs 7002 client modal glitches on Integrations page #7056

merged 3 commits into from
May 29, 2024

Conversation

anamulhaquemollah
Copy link
Contributor

No description provided.

@naftis naftis self-requested a review May 28, 2024 12:29
naftis
naftis approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works great.

One way to make the integrations menu more usable would be to add min-height to ResponsiveModal to not allow it getting too short for the dropdown to stay partially hidden. We can look into that at a later time :)

@naftis naftis merged commit f496990 into develop May 29, 2024
21 checks passed
@naftis naftis deleted the ocrvs-7002 branch May 29, 2024 10:03
Zangetsu101 pushed a commit that referenced this pull request Jun 7, 2024
@anamulhaquemollah @naftis @Zangetsu101
fix: client modal glitches on Integrations-page (#7056)
e3fdfbb 
* ocrvs-7002

* replaced 'auto' with 'scroll'

* changelog.md updated

* fix: react issue with exhaustive deps

---------

Co-authored-by: Pyry <pyry.rouvila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
💅 Waiting For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anamulhaquemollah @naftis