[OCRVS-6163] Fix login config load issue #7010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as we also verify email if the user notification method is set 'email'
rikukissa
approved these changes
May 16, 2024
Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com>
Zangetsu101
approved these changes
May 20, 2024
tahmidrahman-dsi
added a commit
that referenced
this pull request
May 20, 2024
* Rename component file names according to the current convention * Rename PhoneNumberVerificationForm -> AuthDetailsVerificationForm - as we also verify email if the user notification method is set 'email' * Fetch config before rendering react app * Amend withRetry function implementation Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com> * Update CHANGELOG.md --------- Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek.2024-05-16.18-26.mp4