Skip to content

fix(web): make desktop onboarding resilient - #256

Merged
leoisadev1 merged 5 commits into
mainfrom
t3code/fix-random-startup-bugs
Sep 13, 2026
Merged

leoisadev1 merged 5 commits into
mainfrom
t3code/fix-random-startup-bugs

Conversation

@leoisadev1

Copy link
Copy Markdown
Member

Desktop onboarding could advance before the provider catalog arrived, leaving bot creation blocked by a misleading subscription-loading error. Interrupted sign-in also left the completion control busy, and the visually modal setup surface left background controls interactive.

This change preserves the provider catalog's loading state, gates creation on explicit readiness, recovers interrupted sign-in, and stabilizes capture mode across URL normalization. It also makes onboarding a focused modal with an inert background, correct progress semantics, sufficient step-label contrast, and an accessible file input.

Verified with 48 focused web tests, targeted web typecheck and lint, and an isolated end-to-end onboarding run through bot creation and the first-message composer.

Implemented by gpt-5.6-sol using the Codex harness.

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
akeru-bot-landing Skipped Skipped Sep 13, 2026 7:29pm UTC

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 13, 2026
@greptile-apps

greptile-apps Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Greptile Summary

This update improves desktop onboarding reliability and accessibility by distinguishing provider readiness states, preserving sign-in completion after interruptions, keeping development capture mode stable across URL normalization, and improving modal and form semantics.

Confidence Score: 5/5

Safe to merge.

No outstanding findings remain. The keyboard-focus thread was manually resolved by leoisadev1 without explanation. The capture-mode test-coverage thread was manually resolved by leoisadev1 without explanation.

Reviews (3): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

Comment thread apps/web/src/components/onboarding/DesktopOnboarding.tsx
Comment thread apps/web/src/components/onboarding/DesktopOnboarding.test.tsx
@leoisadev1
leoisadev1 merged commit 2b429d3 into main Sep 13, 2026
11 checks passed
@leoisadev1
leoisadev1 deleted the t3code/fix-random-startup-bugs branch September 13, 2026 20:11
This was referenced Sep 13, 2026

This branch was successfully deployed

1 active deployment
Preview — cb49457d Deployed Sep 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant