Repository navigation
feat(shared): map text generation models by provider identity - #253
Merged
Merged
Conversation
Copying a title-generation model by instance id can land on a disabled or different provider on another environment. Map the selection onto a target by enabled driver identity instead, and keep the target's working model when nothing matches. Upstream: pingdotgg#10526 Grok 4.6 High in Grok Build via Orca.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
Greptile SummaryThe provider-selection transfer logic now retains compatible legacy selections and treats any migrated instance for a provider driver as authoritative, preventing disabled migrated providers from being replaced by an enabled legacy fallback. Confidence Score: 5/5Safe to merge. The current implementation fully addresses both previously reported provider-selection behaviors: legacy selections resolve through their provider driver, and the legacy fallback is skipped whenever migrated instances for that driver exist. Reviews (3): Last reviewed commit: "fix(shared): respect disabled migrated p..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
leoisadev1
changed the title
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A future cross-environment settings flow cannot copy a text-generation model by provider instance ID: the same ID may be missing, disabled, or backed by a different provider on the target environment.
Change
Add
textGenerationSelectionForTarget, a shared mapping contract that:providerInstances;Akeru does not yet have T3 Code's Apply to all shared-settings client, so this PR does not claim to synchronize the General setting today. It provides the tested identity-mapping contract for that future flow.
This is an Akeru adaptation of pingdotgg/t3code#10526.
Verification
vp test run packages/shared/src/serverSettings.test.ts— 29 tests passed.Made with GPT-5.6 Sol in T3 Code through the Codex harness.