Repository navigation
perf(server): drop transient native events from provider logs - #240
Merged
Merged
Conversation
Streaming provider chunks were filling thread-scoped ndjson files even though they cannot change thread state. Filter those native events before serialization, push into the pending buffer instead of copying it, and keep ACP protocol logging opt-in with the same chunk filter. Async drain/close for EventNdjsonLogger stays on OPEN #203. Grok 4.6 High via Grok Build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR reduces provider log volume by dropping transient native streaming events before serialization and makes full ACP protocol diagnostics explicitly configurable.
Confidence Score: 5/5Merge-safe. No outstanding blocking issues remain. No accepted new findings or outstanding previous findings remain. The previous ACP protocol logging concern is fully addressed because both Cursor and Grok forward the configured verbose protocol logging setting into ACP native logger construction. Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
This was referenced Sep 10, 2026
# Conflicts: # apps/server/src/provider/Layers/EventNdjsonLogger.ts
This was referenced Sep 14, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Provider event logs no longer persist streaming chunks that cannot change thread state: Codex item/realtime deltas, Claude content-block deltas, ACP
agent_message_chunk/agent_thought_chunk, and OpenCode text/reasoning part updates. Writes push into the pending buffer instead of copying it. ACP request diagnostics stay on; full protocol logging is opt-in through the Cursor and Grok provider settings and applies the same chunk filter.Why
Native streams currently write every delta into thread-scoped ndjson files. Canonical events already drop
content.deltaand similar types. Native events did not, so the files grew with records nobody reads. Remaining pingdotgg#8187 logging work, kept off #230 (narrow projection queries) and off #203 (async log drains).EventNdjsonLogger.tsis shared with OPEN #203. This PR only changes persist filters and pending-buffer mutation. It does not rewrite drain/close.Out of scope here: OpenCode adapter text merge, native telemetry sampling, GitVcsDriver Trace2 decode, RepositoryIdentityResolver root cache (already local).
UI Changes
None.
Checklist
Verification
Grok 4.6 High via Grok Build authored the change. Codex gpt-5.6-sol in T3 Code completed the review fixes.