runtimetest: count correctly TAP tests #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is moving in the direction of #308, which I haven't had time to finish rebasing. I'm fine landing it as an intermediate step, but we'll probably want to (eventually, possibly in follow-up work) follow #308 and convert all of the local validation tests into TAP-harness calls to keep the skips and non-skips in order. |
Don't create a new tap.T in the middle of a test but reuse the existing one instead. Symptoms: ``` $ sudo validation/linux_readonly_paths.t TAP version 13 ok 1 - root filesystem ok 2 - hostname ok 3 - process ok 4 - mounts ok 5 - user ok 6 - rlimits ok 7 - capabilities ok 8 - default symlinks ok 9 - default file system ok 10 - default devices ok 11 - linux devices ok 12 - linux process ok 13 - masked paths ok 14 - oom score adj ok 1 # SKIP syscall action SCMP_ACT_ALLOW ok 2 # SKIP syscall action SCMP_ACT_ALLOW ok 3 # SKIP syscall action SCMP_ACT_ALLOW ok 4 # SKIP syscall action SCMP_ACT_ALLOW ok 5 # SKIP syscall action SCMP_ACT_ALLOW ok 6 # SKIP syscall action SCMP_ACT_ALLOW ok 15 - seccomp ok 16 - read only paths ok 17 - rootfs propagation ok 18 - sysctls ok 19 - uid mappings ok 20 - gid mappings 1..20 ``` After this patch is applied: ``` $ sudo validation/linux_readonly_paths.t TAP version 13 ok 1 - root filesystem ok 2 - hostname ok 3 - process ok 4 - mounts ok 5 - user ok 6 - rlimits ok 7 - capabilities ok 8 - default symlinks ok 9 - default file system ok 10 - default devices ok 11 - linux devices ok 12 - linux process ok 13 - masked paths ok 14 - oom score adj ok 15 # SKIP syscall action SCMP_ACT_ALLOW ok 16 # SKIP syscall action SCMP_ACT_ALLOW ok 17 # SKIP syscall action SCMP_ACT_ALLOW ok 18 # SKIP syscall action SCMP_ACT_ALLOW ok 19 # SKIP syscall action SCMP_ACT_ALLOW ok 20 # SKIP syscall action SCMP_ACT_ALLOW ok 21 - seccomp ok 22 - read only paths ok 23 - rootfs propagation ok 24 - sysctls ok 25 - uid mappings ok 26 - gid mappings 1..26 ``` Fixes opencontainers#593 Signed-off-by: Alban Crequy <alban@kinvolk.io>
alban
force-pushed
the
alban/593-tapError-count
branch
from
399708a to
c9b4d66
Compare
|
@wking I am fine with landing this as an intermediate step. I rebased the branch on the recent master. |
|
LGTM |
|
It works good in my test :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create a new tap.T in the middle of a test but reuse the existing
one instead.
Symptoms:
After this patch is applied:
Fixes #593
Signed-off-by: Alban Crequy alban@kinvolk.io