add 'state' test; using WaitingForStatus in insideValidation#562
Merged
liangchenye merged 2 commits intoopencontainers:masterfrom Feb 5, 2018
Merged
add 'state' test; using WaitingForStatus in insideValidation#562liangchenye merged 2 commits intoopencontainers:masterfrom
liangchenye merged 2 commits intoopencontainers:masterfrom
Conversation
Member
Author
|
6d78ff1 to
778691f
Compare
wking
reviewed
Jan 25, 2018
validation/util/test.go
Outdated
| PostCreate func(runtime *Runtime) error | ||
| PreDelete func(runtime *Runtime) error | ||
| PostDelete func(runtime *Runtime) error | ||
| PreCreate func(runtime *Runtime) ([]byte, error) |
Contributor
There was a problem hiding this comment.
I'd rather not assume that these functions will include something that has a stderr. Can we use *ExitError instead, and have the test include that stderr in their YAML diagnostic if the error casts to *ExitError? I'll work up a PR with that narrow pivot to help show what I'm suggesting.
Contributor
There was a problem hiding this comment.
I'll work up a PR with that narrow pivot to help show what I'm suggesting.
Filed as #564.
bb65534 to
6e50906
Compare
6e50906 to
7843139
Compare
Member
Author
|
need to rebase after #563 |
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
7843139 to
696b805
Compare
Member
Author
|
Updated. PTAL @wking @Mashimiao @q384566678 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liang Chenye liangchenye@huawei.com