Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace colon by comma as separator #524

Closed

Conversation

Mashimiao
Copy link

@Mashimiao Mashimiao commented Nov 23, 2017

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com

This is a temporary try. try to solve separator problem in options. As discussed in #470

Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
@zhouhao3
Copy link

zhouhao3 commented Nov 24, 2017

In general I agree this PR.
Because the args option is a special case. I think it's possible to only change the colon in the parseHook, or to change all the colons in the input to commas. Consistency is easy to use.

@Mashimiao
Copy link
Author

That's not a perfect way to solve the problem, closing it.

@Mashimiao Mashimiao closed this Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants