generate: change process-tty to process-terminal #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangchenye
reviewed
Nov 15, 2017
cmd/oci-runtime-tool/generate.go
Outdated
| @@ -103,7 +103,7 @@ var generateFlags = []cli.Flag{ | |||
| cli.StringSliceFlag{Name: "process-rlimits-add", Usage: "specifies resource limits for processes inside the container. "}, | |||
| cli.StringSliceFlag{Name: "process-rlimits-remove", Usage: "remove specified resource limits for processes inside the container. "}, | |||
| cli.BoolFlag{Name: "process-rlimits-remove-all", Usage: "remove all resource limits for processes inside the container. "}, | |||
| cli.BoolFlag{Name: "process-tty", Usage: "allocate a new tty for the container process"}, | |||
| cli.BoolFlag{Name: "process-terminal", Usage: "specifies terminal attach to the process"}, | |||
There was a problem hiding this comment.
It sounds like setting a terminal with detailed info (size for example).
We can just reuse the word in the spec file: specifies whether a terminal is attached to the process.
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com