Skip to content

Conversation

@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Jan 11, 2017

This gets us to this output:

-----------------------------------------------------------------------------------
VALIDATING RUNTIME: runc
-----------------------------------------------------------------------------------
TAP version 13
ok 1 - root filesystem
ok 2 - hostname
ok 3 - mounts
ok 4 - capabilities
ok 5 - default symlinks
ok 6 - default file system
ok 7 - default devices
ok 8 - linux devices
ok 9 - linux process
ok 10 - masked paths
ok 11 - oom score adj
ok 12 - read only paths
ok 13 - rlimits
ok 14 - sysctls
ok 15 - uid mappings
ok 16 - gid mappings
Runtime runc passed validation

@hqhq @Mashimiao @wking @liangchenye PTAL

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp mrunalp force-pushed the tap_runtime_test branch 2 times, most recently from 98b83c3 to c041300 Compare January 11, 2017 00:32
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Copy link
Contributor Author

mrunalp commented Jan 11, 2017

@RobDolinMS I think this will help us to easily add link to anchors. We can just add another field to the validation struct as a pointer to an anchor in the spec that is being tested.

@Mashimiao
Copy link

That looks like what I have done in d76bbd7e28600f005

@wking
Copy link
Contributor

wking commented Jan 11, 2017 via email

@Mashimiao
Copy link

Mashimiao commented Jan 13, 2017

LGTM

Approved with PullApprove

1 similar comment
@liangchenye
Copy link
Member

liangchenye commented Jan 17, 2017

LGTM

Approved with PullApprove

@liangchenye
Copy link
Member

This frame is much smaller than ginkgo.

@Mashimiao Mashimiao merged commit 0924591 into opencontainers:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants