Tap output from runtime test#302
Merged
Mashimiao merged 2 commits intoopencontainers:masterfrom Jan 17, 2017
Merged
Conversation
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
98b83c3 to
c041300
Compare
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
c041300 to
06f919b
Compare
Contributor
Author
|
@RobDolinMS I think this will help us to easily add link to anchors. We can just add another field to the validation struct as a pointer to an anchor in the spec that is being tested. |
|
That looks like what I have done in d76bbd7e28600f005 |
Contributor
|
On Tue, Jan 10, 2017 at 06:20:22PM -0800, Ma Shimiao wrote:
That looks like what I have done in
[d76bbd7](d76bbd7)
But TAP is a standardized format, and it's nice to not have to roll
our own [1]. And in #285, d76bbd7 was tied up with the change from
#232 that broke test_runtime.sh's exit code (as far as I know, nobody
has written the subreaper wrapper needed to make that work [2]).
I've filed mrunalp/runtime-tools#1 with a more granular take on this PR
(to get squashed in if it looks useful). That PR also uses prove (a
TAP harness) so we get an appropriate exit code from test_runtime.sh.
It's still using ‘start’ (where modern runC's use ‘run’), but I'm
leaving the subreaper wrapper and create/start split for somebody else
to handle ;).
[1]: #285 (comment)
[2]: #232 (comment)
|
1 similar comment
Member
Member
|
This frame is much smaller than ginkgo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets us to this output:
@hqhq @Mashimiao @wking @liangchenye PTAL