Failed tests around mount sources #651
Comments
alban
added a commit
to kinvolk/runc
that referenced
this issue
Jul 18, 2018
PR opencontainers#1753 introduced a test on the mount flags but the binary operator was wrong, see opencontainers#1753 (comment) This was noticed when investigating opencontainers/runtime-tools#651 Symptoms: in the container, /proc/self/mountinfo displays some mounts as follow: 296 279 0:67 / /tmp rw,nosuid - tmpfs /home/dpark/go/src/github.com/opencontainers/runc/tmpfs rw,size=65536k,mode=755 Signed-off-by: Alban Crequy <alban@kinvolk.io>
alban
added a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jul 31, 2018
The runtime-spec says that [mount source is optional]( https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#mounts). So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field. The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes. runc passes the test after opencontainers/runc#1845 Closes: opencontainers#651 Based on work from: Dongsu Park <dongsu@kinvolk.io> Signed-off-by: Alban Crequy <alban@kinvolk.io>
alban
added a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jul 31, 2018
The runtime-spec says that [mount source is optional]( https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#mounts). So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field. The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes. runc passes the test after opencontainers/runc#1845 Closes: opencontainers#651 Based on work from: Dongsu Park <dongsu@kinvolk.io> Signed-off-by: Alban Crequy <alban@kinvolk.io>
alban
added a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jul 31, 2018
The runtime-spec says that [mount source is optional]( https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#mounts). So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field. The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes. runc passes the test after opencontainers/runc#1845 Closes: opencontainers#651 Based on work from: Dongsu Park <dongsu@kinvolk.io> Signed-off-by: Alban Crequy <alban@kinvolk.io>
dongsupark
pushed a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Aug 21, 2018
The runtime-spec says that [mount source is optional]( https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#mounts). So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field. The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes. runc passes the test after opencontainers/runc#1845 Closes: opencontainers#651 Based on work from: Dongsu Park <dongsu@kinvolk.io> Signed-off-by: Alban Crequy <alban@kinvolk.io>
dims
pushed a commit
to dims/libcontainer
that referenced
this issue
Oct 19, 2024
PR #1753 introduced a test on the mount flags but the binary operator was wrong, see opencontainers/runc#1753 (comment) This was noticed when investigating opencontainers/runtime-tools#651 Symptoms: in the container, /proc/self/mountinfo displays some mounts as follow: 296 279 0:67 / /tmp rw,nosuid - tmpfs /home/dpark/go/src/github.com/opencontainers/runc/tmpfs rw,size=65536k,mode=755 Signed-off-by: Alban Crequy <alban@kinvolk.io>
dims
pushed a commit
to dims/libcontainer
that referenced
this issue
Oct 19, 2024
PR #1753 introduced a test on the mount flags but the binary operator was wrong, see opencontainers/runc#1753 (comment) This was noticed when investigating opencontainers/runtime-tools#651 Symptoms: in the container, /proc/self/mountinfo displays some mounts as follow: 296 279 0:67 / /tmp rw,nosuid - tmpfs /home/dpark/go/src/github.com/opencontainers/runc/tmpfs rw,size=65536k,mode=755 Signed-off-by: Alban Crequy <alban@kinvolk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
validation/mounts.tfails with several mount points test failures, such asInside the runc container,
/proc/self/mountinfoshows a corresponding entry:Here the absolute path
/home/dpark/go/src/github.com/opencontainers/runc/tmpfsis interpreted to "mount source", which does not seem to be actually meaningful in this case. However the runtime-tools validation test fails becausecmd/runtimetest/main.gostrictly checks if the given mount source is equal to an expected mount source. That's why the validation test fails.On the other hand, runtime-spec says that
mount sourceis optional, since opencontainers/runtime-spec#699 was merged. So can we just remove the check incmd/runtimetest/main.go?The text was updated successfully, but these errors were encountered: