Skip to content

Support for network namespace in windows #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vbatts merged 1 commit into from
Sep 9, 2018
Merged

Support for network namespace in windows #989

vbatts merged 1 commit into from
Sep 9, 2018

Conversation

@dineshgovindasamy
Copy link
Contributor

@dineshgovindasamy dineshgovindasamy commented Aug 31, 2018 •
edited
Loading

Signed-off-by: Dinesh Govindasamy dingov@microsoft.com
Co-Authored-By: msabansal sabansal@microsoft.com

@dineshgovindasamy dineshgovindasamy mentioned this pull request Aug 31, 2018
Closed
@crosbymichael
Copy link
Member

crosbymichael commented Aug 31, 2018 

git-validation -q -run DCO,short-subject,dangling-whitespace
 9b47594 - FAIL - has whitespace errors. See `git show --check 9b47594383442579c974ef26d9505bdb7a51dcde`.
1 commits to fix
make: *** [.gitvalidation] Error 1

@madhanrm
Copy link

madhanrm commented Aug 31, 2018

@nagiesek

@dineshgovindasamy
Copy link
Contributor Author

dineshgovindasamy commented Aug 31, 2018

@crosbymichael I fixed the whitespaces but the Travis CI is still referring to the old commit and not the new Commit. Is there a way to rerun the CI with latest commit.

@msabansal
Support for network namespace in windows
6f5fcd4 
This is to add network namespace support for Windows

Signed-off-by: Dinesh Govindasamy <dingov@microsoft.com>
Co-Authored-By: msabansal <sabansal@microsoft.com>
@dineshgovindasamy
Copy link
Contributor Author

dineshgovindasamy commented Aug 31, 2018

@crosbymichael Thanks it was the DCO issue. I fixed and now it succeeded.

@dineshgovindasamy
Copy link
Contributor Author

dineshgovindasamy commented Sep 1, 2018

@crosbymichael Could you please approve this PR?

cc @jhowardmsft

@crosbymichael
Copy link
Member

crosbymichael commented Sep 4, 2018 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@dineshgovindasamy
Copy link
Contributor Author

dineshgovindasamy commented Sep 4, 2018

@tianon Could you please approve this PR? Please let me know if you have any questions.

Cc @jhowardmsft

@dineshgovindasamy
Copy link
Contributor Author

dineshgovindasamy commented Sep 5, 2018

@caniszczyk @dqminh @hqhq @mrunalp @philips @vbatts @vishh @tianon Could one of you please approve this PR? i need one more approval for this PR to be merged. We have many PR's pending on this change. This is to bring in namespace support for Windows

@vbatts
Copy link
Member

vbatts commented Sep 9, 2018 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit eba862d into opencontainers:master Sep 9, 2018
@dineshgovindasamy dineshgovindasamy mentioned this pull request Sep 18, 2018
Closed
@thaJeztah thaJeztah mentioned this pull request Sep 27, 2018
Merged
@vbatts vbatts mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dineshgovindasamy @crosbymichael @madhanrm @vbatts