config-linux: describe more about rootfs mount propagation #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Jun 18, 2018
Contributor
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
The new descriptions also talk about "nested containers", but don't define them. I think you want a sentence or two around your "peer group" definition to define "nested containers".
config-linux.md
Outdated
| Its value is either slave, private, shared or unbindable. | ||
| Its value is either `shared`, `slave`, `shared+slave`, `private` or `unbindable`. It's worth noting that a peer group is defined as a group of VFS mounts that propagate events to each other. | ||
|
|
||
| * `shared`: the rootfs mount belongs to a new peer group. This means that further mounts (e.g. nested containers) will also belong to that peer group and will propagate events to the rootfs. Note this does not mean that it's shared with the host. |
Contributor
There was a problem hiding this comment.
nits: these should use four-space indents (#495), and use new lines for each sentence.
dongsupark
force-pushed
the
dongsu/spec-mount-prop
branch
from
a8386c6 to
840d343
Compare
Section of rootfs mount propagation modes should include more descriptions about each propagation mode as well as its actual meaning in the real world. Since the shared subtrees document in the Linux Kernel is not exactly readable for ordinary users, we should elaborate more on this topic in the runtime-spec. Fixes opencontainers#973 Suggested by @alban, @iaguis Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
Author
|
@wking Updated. |
Member
|
house keeping: we've generally avoided copying straight from source materials. But I also agreed that shared subtree propagation is not a fun thing to force on someone. 😉 LGTM |
Closed
Contributor
|
@vbatts |
Member
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section of rootfs mount propagation modes should include more descriptions about each propagation mode as well as its actual meaning in the real world.
Since the shared subtrees document in the Linux Kernel is not exactly readable for ordinary users, we should elaborate more on this topic in the runtime-spec.
Fixes #973
Suggested by @alban, @iaguis
Signed-off-by: Dongsu Park dongsu@kinvolk.io