.travis: Bump minimum Go version to 1.9 #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
May 9, 2018
.travis.yml
Outdated
| - 1.7 | ||
| - 1.6.3 | ||
| - 1.5.4 | ||
| - 1.10 |
Member
There was a problem hiding this comment.
This gets interpreted as 1.1 (and thus fails) -- you probably want to use 1.10.x anyhow (to get the latest minor release in the 1.10 series).
Same with 1.9.x.
See also https://docs.travis-ci.com/user/languages/go/#Specifying-a-Go-version-to-use.
Contributor
Author
Go 1.10 was released on 2018-02-16 [1] and Go only supports the last two major releases [2] (so currently 1.9 and 1.10). Besides ensuring that we are compatible with the currently-maintained releases, this will avoid our current test failure now that golint has dropped support for Go 1.6 [3]: $ make install.tools go get -u github.com/golang/lint/golint # golang.org/x/tools/go/internal/gcimporter ../../../golang.org/x/tools/go/internal/gcimporter/iimport.go:77: undefined: io.SeekCurrent ../../../golang.org/x/tools/go/internal/gcimporter/iimport.go:80: undefined: io.SeekCurrent ../../../golang.org/x/tools/go/internal/gcimporter/iimport.go:156: undefined: io.SeekCurrent ../../../golang.org/x/tools/go/internal/gcimporter/iimport.go:187: r.declReader.Reset undefined (type bytes.Reader has no field or method Reset) ../../../golang.org/x/tools/go/internal/gcimporter/iimport.go:226: r.declReader.Reset undefined (type bytes.Reader has no field or method Reset) make: *** [.install.golint] Error 2 Quoting the versions in the Travis YAML is recommended to avoid them being interpreted as floating point numbers [4]. [1]: https://golang.org/doc/devel/release.html#go1.10 [2]: https://golang.org/doc/devel/release.html#policy [3]: https://travis-ci.org/opencontainers/runtime-spec/jobs/376692151#L469 [4]: https://docs.travis-ci.com/user/languages/go/#Specifying-a-Go-version-to-use Signed-off-by: W. Trevor King <wking@tremily.us>
Avoid: $ make .govet go vet -x ./... schema/validate.go:10:2: cannot find package "github.com/xeipuuv/gojsonschema" in any of: /home/travis/.gimme/versions/go1.10.1.linux.amd64/src/github.com/xeipuuv/gojsonschema (from $GOROOT) /home/travis/gopath/src/github.com/xeipuuv/gojsonschema (from $GOPATH) make: *** [.govet] Error 1 The command "make .govet" exited with 2. with Go 1.10.1 [1]. Go 1.9.5 doesn't seem to mind [2], but it shouldn't mind the presence of the dependencies either. [1]: https://travis-ci.org/opencontainers/runtime-spec/jobs/376991027#L531 [2]: https://travis-ci.org/opencontainers/runtime-spec/jobs/376991028#L529 Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.10 was released on 2018-02-16 and Go only supports the last two major releases (so currently 1.9 and 1.10). Besides ensuring that we are compatible with the currently-maintained releases, this will avoid our current test failure now that golint has dropped support for Go 1.6: