Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meeting: Bump January meeting from the 3rd to the 10th #943

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

wking
Copy link
Contributor

@wking wking commented Dec 7, 2017

Catching up with:

On Thu, Dec 07, 2017 at 09:14:32AM -0600, @caniszczyk wrote:

btw, I bumped the January meeting a week later due to the holidays, that should solve issues and updated the calendar invite

I've used RDATE to add the new date and EXDATE to remove the old date. The ICS was validated here.

Catching up with:

On Thu, Dec 07, 2017 at 09:14:32AM -0600, Chris Aniszczyk wrote [1]:
> btw, I bumped the January meeting a week later due to the holidays,
> that should solve issues and updated the calendar invite

I've used RDATE [2] to add the new date and EXDATE [3] to remove the
old date.  The ICS was validated with [4].

Also add some wiggle room to the README text, although I don't know
that it's worth adding text for each exception there.  After the
meeting, we can leave the exception information in the iCalendar entry
without bothering anyone, but we'd need more churn to remove it from
the README.

[1]: https://groups.google.com/a/opencontainers.org/d/msg/dev/FzclHQsMH_c/QKJMybRkBAAJ
     Subject: Re: 2017-12-06 agenda
     Date: Thu, 7 Dec 2017 09:14:32 -0600
     Message-ID: <CAJg1wMQFVvT+UiJ1gj3m2AzLQEus82eoWRVVtBEe+ZBMxskq=w@mail.gmail.com>
[2]: https://tools.ietf.org/html/rfc5545#section-3.8.5.2
[3]: https://tools.ietf.org/html/rfc5545#section-3.8.5.1
[4]: https://icalendar.org/validator.html

Signed-off-by: W. Trevor King <wking@tremily.us>
@philips
Copy link
Contributor

philips commented Jan 26, 2018

LGTM

Approved with PullApprove

@wking
Copy link
Contributor Author

wking commented Jan 26, 2018

There's not all that much point in merging the January bump now, although we may still want this PR for the “which are usually” wiggle.

@vbatts
Copy link
Member

vbatts commented Apr 4, 2018

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 4ad8e74 into opencontainers:master Apr 4, 2018
@wking wking deleted the 2018-jan-meeting branch April 5, 2018 22:54
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Apr 6, 2018
Generated with:

  $ git remote add project-template git://github.com/opencontainers/project-template.git
  $ git fetch project-template
  $ git show --oneline project-template/master
  61d73a3 (project-template/master) Merge pull request opencontainers#40 from wking/minor-patch-bullet
  $ git merge --squash --allow-unrelated-histories project-template/master
  $ git checkout HEAD -- .pullapprove.yml MAINTAINERS README.md RELEASES.md
  $ git checkout project-template/master -- GOVERNANCE.md LICENSE
  $ emacs README.md CONTRIBUTING.md # unify around project-template's CONTRIBUTING.md approach
  $ emacs meeting.ics  # update link to point at CONTRIBUTING.md#meetings
  $ git commit -sv

I personally prefer non-squash merges to preserve history and ease
future updates, but that approach has not been popular within the OCI
[1,2], so I'm going with a squash-merge here.

I'm sticking with the local RELEASES.md, because it uses four-space
indents.  I've filed [3] to upstream that change.

I've also filed [4] upstreaming our local wording change from 70ba4e6
(meeting: Bump January meeting from the 3rd to the 10th, 2017-12-07,
opencontainers#943).

I've also fixed the GOVERNANCE.md security link in flight with [5].

I've left the other in-flight project-template changes alone [6].

I've wrapped the URL in meetings.ics to avoid [7]:

  Line length should not be longer than 75 characters near line opencontainers#33
  Reference: RFC 5545 3.1. Content Lines

[1]: opencontainers/go-digest#20 (comment)
[2]: opencontainers/runtime-tools#274 (comment)
[3]: opencontainers/project-template#54
[4]: opencontainers/project-template#55
[5]: opencontainers/project-template#34
[6]: https://github.com/opencontainers/project-template/pulls
[7]: https://icalendar.org/validator.html

Signed-off-by: W. Trevor King <wking@tremily.us>
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants