config: Fix “procfs_2” → “proc_2” link label #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
approved these changes
Jul 28, 2017
dqminh
reviewed
Jul 28, 2017
| @@ -842,7 +842,7 @@ Here is a full example `config.json` for reference. | |||
| [cgroup-v1-memory_2]: https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt | |||
| [selinux]:http://selinuxproject.org/page/Main_Page | |||
| [no-new-privs]: https://www.kernel.org/doc/Documentation/prctl/no_new_privs.txt | |||
| [procfs_2]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt | |||
| [proc_2]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt | |||
There was a problem hiding this comment.
shouldnt this be [proc], nothing refers to proc_2.
There was a problem hiding this comment.
shouldnt this be [proc], nothing refers to proc_2.
Good catch :p; I've pushed 4bb68d9 → cae2991 to update the earlier link to use proc_2. You can see the broken link for oomScoreAdj in the 1.0.0 release.
With proc* link labels in both config.md and config-linux.md, we need at least one file to use _2 (see our policy here).
Catching up with 56eb6a1 (modify procfs to proc, 2017-07-28, opencontainers#905), because it's strange to change one link label from "procfs" -> "proc" but leave the other. This will also make it marginally easier to collapse these to a single link label once we convert the spec to a single Markdown file [1]. [1]: https://groups.google.com/a/opencontainers.org/d/msg/dev/1Wwd_MEzSjI/DsCkR-UwAgAJ Subject: [runtime-spec] Hosting 1.0 HTML on opencontainers.org and timing for transition to single-page Markdown Date: Thu, 27 Jul 2017 16:23:40 -0700 Message-ID: <20170727232340.GA24408@valgrind.tremily.us> Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
procfs-to-proc-link-label
branch
from
4bb68d9 to
cae2991
Compare
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching up with #905, because it's strange to change one link label from
procfs→procbut leave the other. This will also make it marginally easier to collapse these to a single link label once we convert the spec to a single Markdown file.