Makefile: Add .install.* to .PHONY #791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $(var:pattern=replacement) syntax is documented in [1]. [1]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html#index-patsubst-1 Signed-off-by: W. Trevor King <wking@tremily.us>
|
why do we need this ? |
|
On Tue, May 09, 2017 at 09:23:14PM -0700, Daniel, Dao Quang Minh wrote:
why do we need this ?
We don't *need* it, but putting targets in .PHONY when they don't
correspond to on-disk files is good practice. See previous discussion
around [1], and a similar addition in #778.
Assuming that we agree that the .install.* targets should be .PHONY,
the TOOLS variable I'm adding just gives us a DRY way to accomplish
that.
[1]: #774 (comment)
|
|
Closing as we are going to remove PHONY |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 10, 2017
The only .PHONY entry we *need* is for schema/validate, since that's a real file but we haven't told Make about its real dependencies (which involve complicated Go lookups). I'm personally in favor of using .PHONY for all targets that aren't on-disk files, because it hints to readers that the rule is not generating a file at the target. But there has been resistance to adding .PHONY entries to all such cases (e.g. [1,2]), so this commit brings us around to a internally-consistent "only use .PHONY when you always need it" position. That means that, for example, users who create files named 'clean' will turn 'clean' the target into a no-op, but runtime-spec maintainers are ok with that. [1]: opencontainers#791 (comment) [2]: opencontainers#791 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$(var:pattern=replacement)syntax is documented here.Spun off from #759.