[Config Linux] Use MUST and MAY for weight and leafWeight #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Dolin
wking
reviewed
Mar 15, 2017
config-linux.md
Outdated
| @@ -361,7 +361,7 @@ The following parameters can be specified to setup the controller: | |||
| * **`weight`** *(uint16, OPTIONAL)* - bandwidth rate for the device, range is from 10 to 1000 | |||
| * **`leafWeight`** *(uint16, OPTIONAL)* - bandwidth rate for the device while competing with the cgroup's child cgroups, range is from 10 to 1000, CFQ scheduler only | |||
|
|
|||
| You must specify at least one of `weight` or `leafWeight` in a given entry, and can specify both. | |||
| You MUST specify at least one of `weight` or `leafWeight` in a given entry, and can specify both. | |||
There was a problem hiding this comment.
While we're cleaning up this line, maybe “can” → “MAY”?
Signed-off-by: Rob Dolin <robdolin@microsoft.com>
RobDolinMS
changed the title
|
The initial 9388832 is missing an email from the Signed-off-by [1].
But it's in a branch in this repo. Maybe someone with push access can
squash the two commits into one and keep the working Signed-off-by?
[1]: https://pullapprove.com/opencontainers/runtime-spec/pull-request/728/requirements/
|
|
@RobDolinMS you shouldn't push branches to origin directly. You can push branches to your fork and then create PRs from there. Thanks! |
|
On Wed, Mar 22, 2017 at 10:48:27AM -0700, Mrunal Patel wrote:
@RobDolinMS you shouldn't push branches to origin directly. You can
push branches to your fork and then create PRs from there. Thanks!
One way to accomplish this would be to remove @RobDolinMS' write
access for this repository. If we still want maintainers to help
polish the PR (since @RobDolinMS has had trouble rebasing in the
past), we can still do that if he allows maintainers to edit his PR
branches [1].
[1]: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
|
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this pull request
Mar 30, 2017
Carry: opencontainers#728 Signed-off-by: Rob Dolin <robdolin@microsoft.com> Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
Commits need to be squashed and one is lack of SOB. And the branch in upstream needs to be deleted. I've carried this in #751 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rob Dolin
Signed-off-by: Rob Dolin robdolin@microsoft.com