Skip to content

[Runtime] Bump ociVersion in example#727

Closed
RobDolinMS wants to merge 1 commit intomasterfrom
RobDolinMS-example-version-bump
Closed

[Runtime] Bump ociVersion in example#727
RobDolinMS wants to merge 1 commit intomasterfrom
RobDolinMS-example-version-bump

Conversation

@RobDolinMS
Copy link
Collaborator

Updates from 0.2.0 to 1.0.0

Signed-off-by: Rob Dolin robdolin@microsoft.com

Updates from 0.2.0 to 1.0.0 

Signed-off-by: Rob Dolin <robdolin@microsoft.com>
@wking
Copy link
Contributor

wking commented Mar 15, 2017 via email

@wking
Copy link
Contributor

wking commented Mar 15, 2017 via email

@hqhq
Copy link
Contributor

hqhq commented Mar 30, 2017

I don't feel it's needed, especially before 1.0 is really landed, I'll close for now and remove the branch in upstream, feel free to open a new PR when this change it suitable.

@hqhq hqhq closed this Mar 30, 2017
@hqhq hqhq deleted the RobDolinMS-example-version-bump branch March 30, 2017 06:28
@wking
Copy link
Contributor

wking commented Mar 30, 2017 via email

@hqhq
Copy link
Contributor

hqhq commented Mar 31, 2017

It's an example and I don't feel it must be landed before 1.0, but I won't object if others want to, since this PR creates branch on upstream repo and didn't change all version examples, @RobDolinMS do you mind opening an new PR if you still want to do this?

Remember to click the Fork button in the upper-right corner to create your own fork and create branches there, thanks.

@wking
Copy link
Contributor

wking commented Jul 10, 2017

It's an example and I don't feel it must be landed before 1.0…

Should we reopen this (and also fix the other stale versions?), since #881 landed recently with a similar change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants