Rename bundlePath to bundle #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosbymichael
force-pushed
the
state
branch
2 times, most recently
from
37ccc22 to
63b02fb
Compare
wking
reviewed
Feb 2, 2017
specs-go/state.go
Outdated
| @@ -6,12 +6,12 @@ type State struct { | |||
| Version string `json:"ociVersion"` | |||
| // ID is the container ID | |||
| ID string `json:"id"` | |||
| // Status is the runtime state of the container. | |||
| // Status is the runtime status of the container. | |||
| Status string `json:"status"` | |||
| // Pid is the process ID for the container process. | |||
| Pid int `json:"pid"` | |||
| // BundlePath is the path to the container's bundle directory. | |||
There was a problem hiding this comment.
You'll want BundlePath → Bundle in this comment too.
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path part is just redundant and runc is already providing
bundleto consumers.Signed-off-by: Michael Crosby crosbymichael@gmail.com