runtime: Remove start's "fails to run" monitoring #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The in-flight runC implementation just fires a signal at the container [1,2]. It doesn't wait around to see if the signal has an effect, or if it causes the container to crash, etc., etc. [1]: https://github.com/opencontainers/runc/blob/28126f8039e226952d099f7376ba11cd9d00a59f/start.go#L29-L30 [2]: https://github.com/opencontainers/runc/blob/28126f8039e226952d099f7376ba11cd9d00a59f/libcontainer/container_linux.go#L253-L258 Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
LGTM |
Contributor
|
Isn't this done by: https://github.com/opencontainers/runc/blob/master/libcontainer/factory_linux.go#L246 ? |
Contributor
Author
|
On Thu, Jun 02, 2016 at 01:59:13AM -0700, Qiang Huang wrote:
The other end of that pipe is held by the host-side ‘create’ process. |
Contributor
|
ok, didn't realize it's for start operation. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-flight runC implementation just fires a signal at the
container. It doesn't wait around to see if the signal has an
effect, or if it causes the container to crash, etc., etc.