Move errors section out of operations #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Errors` section is more like a general description about runtime, if it's a sub-section of `Operations`, it'll be hard for both implementations and tests to define what this `errors` operation really is. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Contributor
|
6d879c8 looks good to me.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Errorssection is more like a general description aboutruntime, if it's a sub-section of
Operations, it'll be hardfor both implementations and tests to define what this
errorsoperation really is.Signed-off-by: Qiang Huang h.huangqiang@huawei.com