Skip to content

Conversation

@hqhq
Copy link
Contributor

@hqhq hqhq commented Apr 8, 2016

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@vbatts
Copy link
Member

vbatts commented Apr 8, 2016

I had left that out for no particular reason. And it's also not in the
makefile for being included in the docs.

On Thu, Apr 7, 2016, 21:46 Qiang Huang notifications@github.com wrote:

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

You can view, comment on, or merge this pull request online at:

#376
Commit Summary

  • Add project.md to table of contents

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#376

@hqhq
Copy link
Contributor Author

hqhq commented Apr 11, 2016

Updated, added it to Makefile as well.

Makefile Outdated
implementations.md \
principles.md \
style.md \
project.md \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add a comment, but these files were in an order that determines how they show up in the PDF/HTML docs.
If you could just put the project.md entry where it corresponds to where you put it in the table of contents. Thanks.

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq
Copy link
Contributor Author

hqhq commented Apr 12, 2016

@vbatts Updated, and added the comment, thanks.

@vbatts
Copy link
Member

vbatts commented Apr 12, 2016

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Apr 13, 2016

LGTM

@mrunalp mrunalp merged commit 3eeb4ff into opencontainers:master Apr 13, 2016
@hqhq hqhq deleted the hq_add_project branch April 14, 2016 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants