travis: add go1.6 and work around golint

[vbatts]

closes #350

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

[wking]

grep -q 'go1.[56]' should be sufficient.

[vbatts]

yeah, but now i'm trying to figure out the proper subterminal return codes,
because this is now failing as grep is not finding the version

On Sat, Mar 19, 2016 at 11:50 AM, W. Trevor King notifications@github.com
wrote:

In .travis.yml
#352 (comment):

@@ -8,13 +9,13 @@ sudo: false

before_install:

• go get golang.org/x/tools/cmd/vet
  • • go get github.com/golang/lint/golint
  • • go version | grep -qE '(go1.5|go1.6)' && go get github.com/golang/lint/golint

grep -q 'go1.[56]' should be sufficient.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/352/files/60c7a94edb5c008ef08bbfecaf22f4758d5a242d#r56750650

[marcosnils]

@vbatts what about doing something like what I did for containerd to check for a minimum version?: docker-archive/containerd@c6680da

[vbatts]

my goodness. Travis is having API threshold issues, but this finally passes.

golint is only done for go1.5 and go1.6.

PTAL

[wking]

cb02ebd looks good to me.

[marcosnils]

@wking @vbatts this won't work with any version greater that 1.6. Have you checked my comment?

#352 (comment) ?

[wking]

On Mon, Mar 21, 2016 at 10:42:32AM -0700, Marcos Nils wrote:

@wking @vbatts this won't work with any version greater that
1.6. Have you checked my comment?

#352 (comment) ?

This approach looks fine to me to, although bumping @vbatts' approach
as we add/remove Go implementations from the Travis config doesn't
seem like it would be too hard.

[vbatts]

@marcosnils I looked, but it's not like the specs code doesn't support prior golang versions, but that we can't use the golint tool.

[marcosnils]

@vbatts exactly. By following the approach I'm proposing you wouldn't have to change the regex each time a new golang version is added to the travis file. You just specify the minimum version which golint needs and that's it.

It might be a good idea also to add the tip version to the travis file so we can know beforehand if any changed made into Go might break something in the specs.

[vbatts]

k. I've updated it, but the travis before_install step would end up overlapping a bit with this PR https://github.com/opencontainers/specs/pull/349/files#diff-b67911656ef5d18c4ae36cb6741b7965R70

I can consolidate one or the other, for it be be cleaner and all done in the Makefile

[marcosnils]

@vbatts +1 to consolidate.

[mrunalp]

@vbatts Is the build expected to pass here?

[vbatts]

@mrunalp all green

[crosbymichael]

LGTM

[mrunalp]

LGTM