-
Notifications
You must be signed in to change notification settings - Fork 600
Remove clarify rootfs item from the ROADMAP #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We discussed this in the face to face meeting and agreed that it makes sense to keep the rootfs as is for flexibility. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
|
@mrunalp: Why does the rootfs have to be part of the Spec? |
|
@vishh We are taking this item out of the roadmap as we don't think that we need any modifications. |
|
What is the rationale to keep the rootfs path configurable? On Wed, Jan 13, 2016 at 12:07 PM, Mrunal Patel notifications@github.com
|
|
On Wed, Jan 13, 2016 at 11:58:15AM -0800, Mrunal Patel wrote:
Looking over 1, the only references I see to ‘rootfs’ are in the |
|
This was discussed yesterday and the conclusion was that bundle authors should be able to name their rootfs whatever they want to. |
|
Ok. Thanks for the clarity. On Wed, Jan 13, 2016 at 12:10 PM, Mrunal Patel notifications@github.com
|
|
Eh, somehow I missed this point yesterday, but I agree with Vish, this On Wed, Jan 13, 2016 at 9:12 PM, Vish Kannan notifications@github.com
|
|
Allowing changing the rootfs allows flexibility in the config. For e.g. one can have two configs point to the same rootfs and invoke the runtime to start readonly containers. We discussed that the bundle verification is separate from what the runtime sees. So, after the bundle is verified, there could be a prepare tool to merge the layers and prepare a rootfs. Next step might be to have two different configs point to the same prepared rootfs. If we don't allow modifying the path to the runtime then we lose this flexibility. |
|
@mrunalp: My understanding is that the current bundle format will contain a json configration along with a directory named I agree that we need to provide an ability to mark the rootfs as |
|
On Wed, Jan 13, 2016 at 12:25:54PM -0800, Vish Kannan wrote:
The current bundle format does not require that name [1](fine with
It's true that you don't need configurable paths (because you can just |
|
Discussing this more the general idea is that it is better for the config to be explicit from the user and not infer anything were we don't have to even if by convention it will most likely be rootfs. LGTM |
|
LGTM |
Remove clarify rootfs item from the ROADMAP
We discussed this in the face to face meeting and agreed
that it makes sense to keep the rootfs as is for flexibility.
Signed-off-by: Mrunal Patel mrunalp@gmail.com