Skip to content

Conversation

@vishh
Copy link
Contributor

@vishh vishh commented Oct 12, 2015

Fixes #114

@vishh
Copy link
Contributor Author

vishh commented Oct 12, 2015

cc @mrunalp

@wking
Copy link
Contributor

wking commented Oct 12, 2015

Are we not happy with the pre-start hook approach to this? See #115
and 1. If not, can someone give more details about where my #115
decision tree breaks down? Is the explicit field approach somehow
easier to use than a pre-start hook? If so, how?

@mrunalp
Copy link
Contributor

mrunalp commented Oct 12, 2015

@vishh Missing Signed-off-by (causing the build to fail).

@vishh
Copy link
Contributor Author

vishh commented Oct 12, 2015

@wking: #114 (comment)

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@mrunalp
Copy link
Contributor

mrunalp commented Oct 12, 2015

LGTM @LK4D4 @crosbymichael ping

@vbatts
Copy link
Member

vbatts commented Oct 26, 2015

LGTM for now. (the cgroups structures had a good deal of discussion)

vbatts added a commit that referenced this pull request Oct 26, 2015
Add oom_score_adj to the runtime Spec.
@vbatts vbatts merged commit f412443 into opencontainers:master Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants