Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Sep 3, 2015

The version field was added while 180df9d (Add runtime state
configuration and structs, 2015-07-29, #87) was in-flight, and it
missed getting documented in the example.

@crosbymichael
Copy link
Member

Can you please rebase this PR? Thanks.

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2015

Rebase and then this will be merged.

@wking wking force-pushed the state-version-example branch from e6b5882 to e12b6d4 Compare October 5, 2015 19:19
@wking
Copy link
Contributor Author

wking commented Oct 5, 2015

On Mon, Oct 05, 2015 at 11:51:15AM -0700, Mrunal Patel wrote:

Rebase and then this will be merged.

Done with e6b5882e12b6d4.

@crosbymichael
Copy link
Member

LGTM

@wking wking force-pushed the state-version-example branch from e12b6d4 to 889f775 Compare December 1, 2015 22:54
The version field was added while 180df9d (Add runtime state
configuration and structs, 2015-07-29, opencontainers#87) was in-flight [1], and it
missed getting documented in the example.

[1]: opencontainers#87 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking mentioned this pull request Dec 1, 2015
@wking
Copy link
Contributor Author

wking commented Dec 1, 2015 via email

@mrunalp
Copy link
Contributor

mrunalp commented Dec 4, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Dec 4, 2015
runtime: Add 'version' to the state.json example
@mrunalp mrunalp merged commit 4a63e81 into opencontainers:master Dec 4, 2015
@wking wking deleted the state-version-example branch December 21, 2015 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants