Skip to content

Conversation

@yzewei
Copy link

@yzewei yzewei commented Oct 16, 2025

Summary

This PR updates the delete operation in the runtime-spec to support deleting multiple containers at once.

Changes

  • Lifecycle section updated to reference one or more container IDs for delete
  • Delete operation signature updated to delete <container-id> [<container-id> ...]
  • Errors must be reported per container; one failing container does not block others

Motivation

Maintainers requested an update to the specification to clarify multi-container delete semantics before implementing multi-delete support in runtimes.

Signed-off-by: yzewei <yangzewei@loongson.cn>
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK.

These runtime operations are meant to be as minimal as possible, and may not even describe a CLI interface. In other words, not every runc feature needs to also become part of the runtime-spec.


### <a name="runtimeDelete" />Delete
`delete <container-id>`
`delete <container-id> [<container-id> ...]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these operations are not specifying any command-line APIs, and the parameters are inputs for general operations.

I agree with @cyphar

This seems to be the scope of the runc's implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants