Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax in Seccomp's errnoRet description #1277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix syntax in Seccomp's errnoRet description #1277

wants to merge 1 commit into from

Conversation

z63d
Copy link

@z63d z63d commented Feb 3, 2025

There is a subtle difference in syntax between Seccomp's defaultErrnoRet and errnoRet, so i will unify the syntax.

runtime-spec/config-linux.md

Line 722 in a5b0116

If not specified then its default value is `EPERM`.

runtime-spec/config-linux.md

Line 797 in a5b0116

If not specified its default value is `EPERM`.

Or you could just reference one of them like this...

runtime-spec/config-linux.md

Line 718 in a5b0116

* **`defaultAction`** *(string, REQUIRED)* - the default action for seccomp. Allowed values are the same as `syscalls[].action`.

@z63d z63d force-pushed the fix/seccomp-errnoret-descripton branch 2 times, most recently from e575d82 to 8617272 Compare February 3, 2025 23:32
@z63d
Fix syntax in Seccomp's errnoRet description
5cb64f9 
Signed-off-by: z63d <kaita.nakamura0830@gmail.com>
@z63d z63d force-pushed the fix/seccomp-errnoret-descripton branch from 8617272 to 5cb64f9 Compare February 3, 2025 23:34
kolyshkin
kolyshkin reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just say "The default is EPERM" in both cases.

Cc @cyphar

@giuseppe
Copy link
Member

giuseppe commented Feb 4, 2025

agreed. "The default is EPERM" should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin left review comments

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda AkihiroSuda is a code owner

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe giuseppe is a code owner

@hqhq hqhq Awaiting requested review from hqhq hqhq is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@thaJeztah thaJeztah Awaiting requested review from thaJeztah thaJeztah is a code owner

@tianon tianon Awaiting requested review from tianon tianon is a code owner

@utam0k utam0k Awaiting requested review from utam0k utam0k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z63d @giuseppe @kolyshkin