MAINTAINERS: remove philips #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributions over the years!! LGTM @vbatts @caniszczyk do you think we need to enforce the DCO on such a trivial commit, or can we go ahead without that for this? |
|
(Also, do we really need three separate systems checking DCO?? 😅) |
|
I was wondering about that. I might can force push over it.
…-------- Original Message --------
On Jan 31, 2020, 19:34, Tianon Gravi wrote:
Thanks for your contributions over the years!!
LGTM
***@***.***(https://github.com/vbatts) ***@***.***(https://github.com/caniszczyk) do you think we need to enforce the DCO on such a trivial commit, or can we go ahead without that for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#1028?email_source=notifications&email_token=AAAQL2J6A4TQ2C7YNDPY7UTRAS7QBA5CNFSM4KN7UHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQN5UA#issuecomment-580968144), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAQL2O3KOX43TKNIRWGXBDRAS7QBANCNFSM4KN7UHOA).
|
|
We.. Have three checks for DCO?
…-------- Original Message --------
On Jan 31, 2020, 19:36, Tianon Gravi wrote:
(Also, do we really need three separate systems checking DCO?? 😅)
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#1028?email_source=notifications&email_token=AAAQL2N7HYW2EWSSLGW75QLRAS7YJA5CNFSM4KN7UHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQOAEI#issuecomment-580968465), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAQL2O3XIYPDEGINYC4ZELRAS7YJANCNFSM4KN7UHOA).
|
vbatts
force-pushed
the
philips-patch-1
branch
from
c9eb9af to
73483a5
Compare
|
fixed |
|
LGTM |
|
pullapprove is confused. Fixed in #1029 |
|
Big thanks to all your effort and history on this spec, @philips |
vbatts
force-pushed
the
philips-patch-1
branch
from
73483a5 to
21c725b
Compare
Signed-off-by: Brandon Philips <brandon@ifup.org> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
philips-patch-1
branch
from
21c725b to
bacc285
Compare
|
LGTM |
|
LGTM ❤️ |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.