Skip to content

Conversation

@KentaTada
Copy link
Contributor

@KentaTada KentaTada commented Apr 19, 2019

LinuxNamespaceType is defined but it is only used for PIDNamespace.
I think all Namespaces should use this type.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@KentaTada
Copy link
Contributor Author

Could you review this commit? cc @vbatts @crosbymichael @cyphar @alban
BTW, I don't know why checks were failed although "Signed-off-by" was added.

@tianon
Copy link
Member

tianon commented May 7, 2019

LGTM

Approved with PullApprove

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@crosbymichael
Copy link
Member

crosbymichael commented May 7, 2019

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 5b71a03 into opencontainers:master May 7, 2019
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants