Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pid file when not exist #597

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Conversation

rajasec
Copy link
Contributor

@rajasec rajasec commented Feb 27, 2016

Currently pid-file over riding the previous container pid-file and moreover there is chance of over riding the host files using create. added the fix to create the file only if not exists
Signed-off-by: rajasec rajasec79@gmail.com

Signed-off-by: rajasec <rajasec79@gmail.com>
@rajasec
Copy link
Contributor Author

rajasec commented Mar 9, 2016

@crosbymichael @mrunalp
Instead of adding the comment I have closed the PR by mistake. I'm reopening now

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Mar 9, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Mar 9, 2016
Create pid file when not exist
@mrunalp mrunalp merged commit c40bd43 into opencontainers:master Mar 9, 2016
@rajasec rajasec deleted the pidfile branch March 10, 2016 01:33
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
…-namespaces

Forbid duplicated namespaces with same `type`.
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
Alternative of opencontainers#583 , as what we do for `namespaces`
in opencontainers#597 .

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants