Use single decoder instance for one stream #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid part of the stream be read and abandomed and resulting decoding errors. Signed-off-by: Hushan Jia <hushan.jia@gmail.com>
|
Not first time we hit that. Change makes sense |
|
LGTM |
1 similar comment
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Feb 28, 2016
Use single decoder instance for one stream
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Add some related docs links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when the process finishes, runc fails with error like:
error: [10] System error: invalid character 'a' looking for beginning of value
This is because part of encoded string was read and abandoned when decoding a smaller type.
This fix will avoid part of the stream be read and abandomed by using a single instance of Decoder
for the stream.
Signed-off-by: Hushan Jia hushan.jia@gmail.com