ci: only run lint-extra job on PRs to main #4937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the new code appears in main (not in the release branches), and we only want extra linter rules to apply to new code. Disable lint-extra job if the PR is not to the main branch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR restricts the lint-extra job to only run on pull requests targeting the main branch, preventing extra linter rules from being applied to release branch PRs where they may not be relevant.
- Updated the condition for the lint-extra step to check both that it's a pull request and that the base ref is 'main'
- Updated the comment to clarify the new behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cyphar
approved these changes
Oct 16, 2025
cyphar
added
backport/1.2-todo
lifubang
approved these changes
Oct 16, 2025
This was referenced Oct 16, 2025
lifubang
added
backport/1.2-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the new code appears in main (not in the release branches), and we only want extra linter rules to apply to new code.
Disable lint-extra job if the PR is not to the main branch.
Inspired by lint-extra warnings in release-1.x PRs.