Skip to content

Conversation

@marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 31, 2025

Prevent --l3-cache-schema from clearing the intel_rdt.memBwSchema state and --mem-bw-schema clearing l3_cache_schema, respectively.

Prevent --l3-cache-schema from clearing the intel_rdt.memBwSchema state
and --mem-bw-schema clearing l3_cache_schema, respectively.

Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
@marquiz
Copy link
Contributor Author

marquiz commented Aug 1, 2025

ping @kolyshkin @AkihiroSuda

@lifubang
Copy link
Member

lifubang commented Aug 1, 2025

I think this is a bug, maybe we need to do the backports to 1.3 and 1.2?

@lifubang lifubang merged commit e20b2c7 into opencontainers:main Aug 1, 2025
31 checks passed
@marquiz marquiz deleted the devel/runc-update-rdt-single-schema branch August 1, 2025 11:27
@marquiz
Copy link
Contributor Author

marquiz commented Aug 1, 2025

I think this is a bug, maybe we need to do the backports to 1.3 and 1.2?

Yeah, probably. I can do that if needed.

Related question: could you educate me on is the config (especially the rdt parts) in state.json actually used for anything or is it only fyi for the higher level runtime?

@lifubang
Copy link
Member

lifubang commented Aug 1, 2025

Related question: could you educate me on is the config (especially the rdt parts) in state.json actually used for anything or is it only fyi for the higher level runtime?

After a container is created, all configuration settings from config.json are serialized into state.json, along with additional runtime information such as the PID of the container's main process. Subsequent runc commands rely on state.json to retrieve both the container's configuration and the main process PID using the container's name.

Additionally, operations such as runc update will also modify the state.json file to reflect updated resource constraints or configurations.

Therefore, the data in state.json is not just for informational purposes—it is actively used by runc to manage and interact with running containers.

@lifubang lifubang added backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 labels Aug 1, 2025
@lifubang lifubang added backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3 and removed backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/intelrdt backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3 kind/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants