Skip to content

Conversation

@chenx97
Copy link
Contributor

@chenx97 chenx97 commented Apr 10, 2025

Similar to #1824, we need to convert the device number to uint64 for mips.

Signed-off-by: Henry Chen henry.chen@oss.cipunited.com

Similar to opencontainers#1824, we need to convert the device number to uint64 for
mips.

Signed-off-by: Henry Chen <henry.chen@oss.cipunited.com>
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 10, 2025
- Backport a pre-upstream patch to fix build on MIPS.
- Track patches at AOSC-Tracking/runc @ aosc/v1.2.6
  (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2).

Link: opencontainers/runc#4723
@MingcongBai
Copy link

Build tested on MIPS64 Release 2 platform (Loongson 3B4000), thanks!

MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 10, 2025
- Backport a pre-upstream patch to fix build on MIPS.
- Track patches at AOSC-Tracking/runc @ aosc/v1.2.6
  (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2).

Link: opencontainers/runc#4723
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 10, 2025
- Backport a pre-upstream patch to fix build on MIPS.
- Track patches at AOSC-Tracking/runc @ aosc/v1.2.6
  (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2).

Link: opencontainers/runc#4723
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 10, 2025
- Backport a pre-upstream patch to fix build on MIPS.
- Track patches at AOSC-Tracking/runc @ aosc/v1.2.6
  (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2).

Link: opencontainers/runc#4723
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Now runc compilation and runc tests work fine on your MIPS?

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm )

@rata rata merged commit 0219733 into opencontainers:main Apr 14, 2025
34 checks passed
@rata
Copy link
Member

rata commented Apr 14, 2025

Do we want to backport this to 1.2 and 1.3?

@chenx97 chenx97 deleted the stat-uint32-mips branch April 16, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants