-
Notifications
You must be signed in to change notification settings - Fork 2.2k
tests/cmd/remap-rootfs: fix mips builds #4723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Similar to opencontainers#1824, we need to convert the device number to uint64 for mips. Signed-off-by: Henry Chen <henry.chen@oss.cipunited.com>
- Backport a pre-upstream patch to fix build on MIPS. - Track patches at AOSC-Tracking/runc @ aosc/v1.2.6 (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2). Link: opencontainers/runc#4723
|
Build tested on MIPS64 Release 2 platform (Loongson 3B4000), thanks! |
- Backport a pre-upstream patch to fix build on MIPS. - Track patches at AOSC-Tracking/runc @ aosc/v1.2.6 (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2). Link: opencontainers/runc#4723
- Backport a pre-upstream patch to fix build on MIPS. - Track patches at AOSC-Tracking/runc @ aosc/v1.2.6 (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2). Link: opencontainers/runc#4723
- Backport a pre-upstream patch to fix build on MIPS. - Track patches at AOSC-Tracking/runc @ aosc/v1.2.6 (HEAD: 617004be4fdb2e95c77ce500364b05d608dbdfc2). Link: opencontainers/runc#4723
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
Now runc compilation and runc tests work fine on your MIPS?
kolyshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
kolyshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm )
|
Do we want to backport this to 1.2 and 1.3? |
Similar to #1824, we need to convert the device number to uint64 for mips.
Signed-off-by: Henry Chen henry.chen@oss.cipunited.com