go.mod: rm toolchain #4717
Merged
go.mod: rm toolchain #4717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added by dependabot in commit 0b53626. Seems there is a bug about it: dependabot/dependabot-core#11933. Having "toolchain" means instead of using installed go version to build/test, the version specified in toolchain is [downloaded and] used, which might not be what we actually want. For more details on toolchain directive, see https://go.dev/doc/toolchain. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Apr 9, 2025
Member
|
Let's hope this doesn't cause dependabot to add it again later. Let's see :) |
Member
|
I saw other people complaining about it being added automatically. Hopefully this gets fixed (maybe we should add a CI lint to block it, just to be sure). |
Contributor
Author
Sometimes it is useful, for example, see commit 319e133 / PR #4407, but unless we come across something like #4233 again, we should not use |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added by dependabot in commit 0b53626. Seems there is a bug about it: dependabot/dependabot-core#11933.
Having "toolchain" means instead of using installed go version to build/test, the version specified in toolchain is [downloaded and] used, which might not be what we actually want.
For more details on toolchain directive, see
https://go.dev/doc/toolchain.