Skip to content

Add white list for bind mount check#452

Merged
mrunalp merged 1 commit intoopencontainers:masterfrom
hqhq:hq_bindmount_whitelist
Jan 6, 2016
Merged

Add white list for bind mount check#452
mrunalp merged 1 commit intoopencontainers:masterfrom
hqhq:hq_bindmount_whitelist

Conversation

@hqhq
Copy link
Contributor

@hqhq hqhq commented Jan 4, 2016

Fixes: #400

It would be useful to use fuse to isolate proc info.

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@dqminh
Copy link
Contributor

dqminh commented Jan 4, 2016

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hqhq
small typo in the comment, "invalid destionations" -> invalid destinations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajasec Thanks, updated.

@hqhq hqhq force-pushed the hq_bindmount_whitelist branch from 6f3fadb to 566abcc Compare January 5, 2016 01:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add why these files were chosen and use cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrunalp Updated.

Fixes: opencontainers#400

It would be useful to use fuse to isolate proc info.

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq hqhq force-pushed the hq_bindmount_whitelist branch from 566abcc to 9c1242e Compare January 6, 2016 07:49
@mrunalp
Copy link
Contributor

mrunalp commented Jan 6, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Jan 6, 2016
Add white list for bind mount check
@mrunalp mrunalp merged commit 4fda64b into opencontainers:master Jan 6, 2016
@hqhq hqhq deleted the hq_bindmount_whitelist branch January 7, 2016 08:37
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
…stem-owners

config-linux: Make “don't modify filesystem permissions” generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants