Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Don't read COMMIT, BUILDTAGS, EXTRA_BUILDTAGS from env vars #4380

Merged
merged 1 commit into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. Makefile: Don't read COMMIT, BUILDTAG, EXTRA_BUILDTAGS from env vars

    We recently switched VERSION to be read from env vars (opencontainers#4270). This
    broke several projects, as they were building runc and using a `VERSION`
    env var for, e.g. the containerd version.
    
    When fixing that in opencontainers#4370, we discussed to consider doing the same for
    these variables too
    (opencontainers#4370 (review)).
    
    Let's stop reading them from env vars, as it is very easy to do it by
    mistake (e.g. compile runc and define a COMMIT env var, not to override
    the commit shown in `runc --version`) and users that want can still
    override them if they want to. For example, with:
    
    	make EXTRA_BUILDTAGS=runc_nodmz
    
    Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
    rata committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    767bc00 View commit details
    Browse the repository at this point in the history