Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error of runc doesn't work with go1.22 #4193

Closed
wants to merge 4 commits into from
Closed

Fix the error of runc doesn't work with go1.22 #4193

wants to merge 4 commits into from

Commits on May 17, 2024

  1. bump go to 1.22.x 

    Signed-off-by: lifubang <lifubang@acmcoder.com>
    @lifubang
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6916425 View commit details
    Browse the repository at this point in the history

  2. use fork to replace clone(CLONE_PARENT) 

    As the description in opencontainers#4233, there is a bug in glibc, pthread_self()
will return wrong info after we do `clone(CLONE_PARENT)` in libct/nsenter,
it will cause runc can't work in `go 1.22.*`. So we use fork(2) to replace
clone(2) in libct/nsenter, but there is a double-fork in nsenter, so we
need to use `PR_SET_CHILD_SUBREAPER` to let runc can reap grand child
process in libct/nsenter.

Signed-off-by: lifubang <lifubang@acmcoder.com>
    @lifubang
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a2d4311 View commit details
    Browse the repository at this point in the history

  3. Revert "ci/cross-i386: pin Go to 1.21.x" 

    This reverts commit ac31da6.

Signed-off-by: lifubang <lifubang@acmcoder.com>
    @lifubang
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2366a6b View commit details
    Browse the repository at this point in the history

  4. Revert "[hotfix] nsenter: refuse to build with Go 1.22 on glibc" 

    This reverts commit e377e16.

Signed-off-by: lifubang <lifubang@acmcoder.com>
    @lifubang
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1e60e59 View commit details
    Browse the repository at this point in the history