tests/int: fix flaky "runc run with tmpfs perm" #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, sometimes a short-lived "runc run" produces result with \r and sometimes without. As a result, we have an occasional failure of "runc run with tmpfs perms" test. The solution (to the flaky test) is to use the first line of the output (like many other tests do). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Can't say it for sure if the issue with the flaky test is fixed but it should be. |
lifubang
approved these changes
Oct 27, 2023
kolyshkin
added
area/ci
backport/1.1-todo
|
We may need to backport it to release-1.1 branch to avoid flakes in there (no rush though). |
|
@thaJeztah PTAL (kinda easy-to-review) |
AkihiroSuda
approved these changes
Nov 4, 2023
Do we have an issue ticket to track this? |
|
1.1 backport: #4241 |
kolyshkin
added
backport/1.1-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, sometimes a short-lived "runc run" produces result with \r and sometimes without. As a result, we have an occasional failure of "runc run with tmpfs perms" test.
The solution (to the flaky test) is to use the first line of the output (like many other tests do).
Fixes: #4029