Dockerfile: use binary criu release; update some ci deps #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianreber
reviewed
Nov 28, 2020
|
Looks good. The CentOS 7 and Fedora 33 tests were already using my packages and now also the Ubuntu based test. I had a look at the test logs and CRIU is actually installed in all cases from a package and the checkpoint/restore tests are being run everywhere. |
mrunalp
previously approved these changes
Nov 30, 2020
kolyshkin
force-pushed
the
dont-compile-criu
branch
3 times, most recently
from
1792a0e
to
8f1d0f1
Compare
AkihiroSuda
reviewed
Dec 2, 2020
This "reverts" commit 9ff7b82. We use the repo provided and maintained by the CRIU team instead of compiling it from source. While at it, 1. Don't install packages that were solely needed to compile CRIU. 2. Combine all apt-related stuff into a single step, so we don't download and then remove apt metadata 3 times. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
dont-compile-criu
branch
from
8f1d0f1
to
be56333
Compare
kolyshkin
changed the title
AkihiroSuda
approved these changes
Dec 3, 2020
mrunalp
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @adrianreber in checkpoint-restore/criu#1293 (comment)
This "reverts" commit 9ff7b82. We use the repo provided and maintained
by the CRIU team instead of compiling it from source.
While at it,
download and then remove apt metadata 3 times.
TODO:* have CRIU make a Debian repo* remove packages that are needed to build CRIU