ci: add integration / unit tests to github actions #2690
Conversation
kolyshkin
force-pushed
the
gh-act-int
branch
5 times, most recently
from
dbb8301
to
2f0dec8
Compare
kolyshkin
force-pushed
the
gh-act-int
branch
9 times, most recently
from
9590745
to
d10a4e3
Compare
|
OK, half the tests are working now, the other half complains:
One way to fix is to use run tests under docker. There's a bug with lots of comments about it: actions/runner#241 Will take a look later. |
kolyshkin
force-pushed
the
gh-act-int
branch
8 times, most recently
from
ee5f6b9
to
28899fc
Compare
kolyshkin
changed the title
kolyshkin
force-pushed
the
gh-act-int
branch
from
28899fc
to
7af9c0c
Compare
kolyshkin
force-pushed
the
gh-act-int
branch
2 times, most recently
from
8354ffe
to
2943f07
Compare
kolyshkin
force-pushed
the
gh-act-int
branch
2 times, most recently
from
d1b6288
to
ee5ca7d
Compare
|
OK I think this is ready for prime time. I don't mean to replace travis (yet?), it's just in addition to get a faster test results. @AkihiroSuda @mrunalp PTAL |
kolyshkin
force-pushed
the
gh-act-int
branch
from
ee5ca7d
to
fc3f0c3
Compare
This is Ubuntu 20.04 so cgroup v1 testing only :( The upside is, it's pretty fast (currently all the tests finish within 5 minutes). rootless tests take longer time so we run them in parallel with non-rootless ones. Also, to balance the time, we run unit tests when rootless is not set. IOW, 'rootless' in job name means it's only rootless integration tests, and no rootless means it's unit tests, integration tests with fs driver, and integration tests with systemd driver. Note, `script` is used to run integration tests to provide a tty (which by default is not available on gh actions). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
gh-act-int
branch
from
fc3f0c3
to
c1ef0cf
Compare
kolyshkin
changed the title
|
Ahh, interesting... |
I barely remember something about this logging being a tad racy, and I've been trying to fix that in #2487. Oh yes, this ugly commit: f9b4cf0 Alas, I haven't finished that PR and I don't even remember why now. Let me try to revive it... |
In the meantime, this PR is fine, the flake in debug logging is known problem (and a very minor one, since this is runc debug logging no one but a few runc devs care about). |
|
@AkihiroSuda @mrunalp PTAL |
Sorry I overlooked it. Indeed, the situation with Travis is unclear, and GH actions are (currently) both fast and free (and in case they won't be, we could ask LF to pay for it). I am also thinking about using https://cirrus-ci.org/ as it supports Fedora so we can test cgroupv2. |
Seems to need nested VM? (which is also supported by GHA on macOS instances) |
This is Ubuntu 20.04 so alas cgroup v1 testing only.
The upside is it's pretty fast ⏩ we have results of unit + integration tests
for both go 1.14 and 1.15 within 5 minutes. This seems useful now when travis-ci.org
is throttling jobs 😞
rootless tests take longer time so we run them in parallel
with non-rootless ones. Also, to balance the time, we run
unit tests when rootless is not set. IOW, 'rootless' in job
name means it's only rootless integration tests, and no rootless
means it's unit tests, integration tests with fs driver, and
integration tests with systemd driver.
Note,
scriptis used to run integration tests to provide a tty(which by default is not available on gh actions).