Add --all flag to kill #1180
Merged
Add --all flag to kill #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I think it will be better to update the manual for the new flag at the same time. |
|
Also the |
|
I may be confused, but doesn't killing the init of a container guarantee that the container will die? How can a pidns survive without an init? |
|
If you are sharing the host pid namespace or the pid namespace of another container, it will not kill all processes. |
This allows a user to send a signal to all the processes in the container within a single atomic action to avoid new processes being forked off before the signal can be sent. This is basically taking functionality that we already use being `delete` and exposing it ok the `kill` command by adding a flag. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
kill-all
branch
from
53c22f8 to
e58671e
Compare
|
I updated the completions and man pages for this new flag. |
|
LGTM |
1 similar comment
|
LGTM |
runcom
added a commit
to projectatomic/runc
that referenced
this pull request
Nov 17, 2016
Fix BZ#1391665 Upstream reference: opencontainers/runc#1180 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to send a signal to all the processes in the
container within a single atomic action to avoid new processes being
forked off before the signal can be sent.
This is basically taking functionality that we already use being
deleteand exposing it ok thekillcommand by adding a flag.Signed-off-by: Michael Crosby crosbymichael@gmail.com