Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCheckpoint and TestUsernsCheckpoint are failing on centos-stream-9 (Segmentation fault) #3532

Open
AkihiroSuda opened this issue Jul 20, 2022 · 5 comments
Open

TestCheckpoint and TestUsernsCheckpoint are failing on centos-stream-9 (Segmentation fault) #3532

AkihiroSuda opened this issue Jul 20, 2022 · 5 comments
Labels
area/checkpoint-restore area/ci

Comments

@AkihiroSuda
Copy link
Member

https://cirrus-ci.com/task/4890404691640320?logs=unit_tests#L1358

    checkpoint_test.go:163: (00.023368) pie: 1: restoring lsm profile (current) unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
    checkpoint_test.go:163: (00.023421) Error (criu/cr-restore.c:1510): 65440 stopped by signal 11: Segmentation fault
    checkpoint_test.go:163: (00.023704) mnt: Switching to new ns to clean ghosts
    checkpoint_test.go:163: (00.023809) Error (criu/cr-restore.c:2536): Restoring FAILED.
    checkpoint_test.go:163: === END ===
    checkpoint_test.go:164: criu failed: type NOTIFY errno 0
        log file: /tmp/TestCheckpoint1076343382/003/criu/restore.log
--- FAIL: TestCheckpoint (0.33s)
@thaJeztah
Copy link
Member

/cc @kolyshkin @adrianreber

@adrianreber
Copy link
Contributor

The latest glibc changed the restartable sequence interface and that requires a CRIU rebuild. Rebuild is already triggered: https://gitlab.com/redhat/centos-stream/rpms/criu/-/commit/b6cb718321341b624fc6f2a217d04da775ae32a1 but it might take a week or so to show up in the repositories.

@rst0git FYI

@thaJeztah
Copy link
Member

Thanks for the update!

@rst0git rst0git mentioned this issue Jul 20, 2022
Merged
kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 27, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
8857650 
Older criu versions fails to work with userns due to changes in glibc's
rseq. Skip a test if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin mentioned this issue Jul 27, 2022
Merged
@kolyshkin
Copy link
Contributor

This is being fixed in criu-3.17-4.el9 (which is not in the repo yet).

Workaround: #3539

kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 27, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
0bca182 
Older criu builds fail on CentOS Stream 9 due to changes in glibc's
rseq. Skip a test if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 27, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
ea6080f 
Older criu builds fail on CentOS Stream 9 due to changes in glibc's
rseq. Skip a test if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 0bca182)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 27, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
5794655 
Older criu builds fail on CentOS Stream 9 due to changes in glibc's
rseq. Skip a test if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 28, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
2d79c22 
Older criu builds fail to work properly on CentOS Stream 9 due to
changes in glibc's rseq.

Skip criu tests if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/runc that referenced this issue Jul 28, 2022
@kolyshkin
CI: workaround CentOS Stream 9 criu issue
3ca5673 
Older criu builds fail to work properly on CentOS Stream 9 due to
changes in glibc's rseq.

Skip criu tests if an older criu version is found.

Fixes: opencontainers#3532

Cherry picked from commit 4fd4af5.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@cyphar cyphar closed this as completed in 4fd4af5 Jul 28, 2022
@thaJeztah
Copy link
Member

@kolyshkin do you think we should reopen this ticket for tracking ("remove the workaround once we can"?)

@AkihiroSuda AkihiroSuda reopened this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/checkpoint-restore area/ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thaJeztah @kolyshkin @adrianreber @AkihiroSuda